Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keycloak] Add test coverage for importing group from keycloak #11605

Closed
amrita-shrestha opened this issue Sep 18, 2024 · 5 comments
Closed

[keycloak] Add test coverage for importing group from keycloak #11605

amrita-shrestha opened this issue Sep 18, 2024 · 5 comments
Assignees
Labels

Comments

@amrita-shrestha
Copy link
Contributor

amrita-shrestha commented Sep 18, 2024

Describe

oCIS now supports importing groups from keycloak owncloud/ocis#5538

Tests coverage

  • add api request to create group at keycloak and sync group to oCIS

Point to Note

  • docker image should be ocis-7.0.0-rc.1 or rolling
@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Oct 1, 2024

It seems on oCIS with keycloak setup, group will sync to ocis-web only when group assigned user login on ocis-web.

ocis feature

We only get to know the new group membership when the user logs in (via the claims submitted in the access token or in the userinfo). There is not active sync between the IDP and ocis going on.

Finding

to sync a group on oCIS, we have to log in group assigned user first which seems off-the-track with our current web e2e test scenarios until there is active sync feature support on oCIS we can't do much. Either we have to make a separate test suite to test keycloak-group

cc @saw-jan @ScharfViktor do we want to add separate test suite for keycloak-group ?

@ScharfViktor
Copy link
Contributor

cc @saw-jan @ScharfViktor do we want to add separate test suite for keycloak-group ?

yes, for such cases, I would create a separate test suite and exclude it in ocis ci and in web ci ( usual tests).

@saw-jan
Copy link
Member

saw-jan commented Oct 1, 2024

By the looks of this, it seems that we have to do workarounds in existing groups related tests to them run with keycloak.

cc @saw-jan @ScharfViktor do we want to add separate test suite for keycloak-group ?

yes, for such cases, I would create a separate test suite and exclude it in ocis ci and in web ci ( usual tests).

Yeah, would be good to have minimal group test scenario only for keycloak.

@amrita-shrestha
Copy link
Contributor Author

The approach to create a group using keycloak API has been dropped (demo PR- #11876 )due to the oCIS 5-minute synchronization time as a detailed explanation is provided on https://owncloud.dev/services/proxy/#claim-updates

@amrita-shrestha
Copy link
Contributor Author

#11887 PR has been merged so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants