We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom
Copy
Atom is just a wrapper around &str, so could be Copy.
&str
I thought previously that we should avoid making Atom Copy in case we had a future reason for them not to be, like some form of reference-counting.
But now I can't see any such reason. Even if we store hash of string inside Atom (#46), that wouldn't prevent Atom being Copy.
This change would remove a ton of atom.clone() from all over the codebase.
atom.clone()
The text was updated successfully, but these errors were encountered:
IntoIn<'a, Atom<'a>>
AstBuilder
No branches or pull requests
Atom
is just a wrapper around&str
, so could beCopy
.I thought previously that we should avoid making
Atom
Copy
in case we had a future reason for them not to be, like some form of reference-counting.But now I can't see any such reason. Even if we store hash of string inside
Atom
(#46), that wouldn't preventAtom
beingCopy
.This change would remove a ton of
atom.clone()
from all over the codebase.The text was updated successfully, but these errors were encountered: