From 80d80b70c0984bcbd175d49045aaccb2c14510ed Mon Sep 17 00:00:00 2001 From: Valentinas Janeiko <2305836+valeneiko@users.noreply.github.com> Date: Fri, 6 Sep 2024 11:30:26 +0100 Subject: [PATCH] ci: Passthrough OXC_VERSION and JEMALLOC_SYS_WITH_LG_PAGE to build container (#5531) Fixes: - https://github.com/oxc-project/oxc/issues/4891 Currently only Mac OS and Windows versions return correct version. Linux versions still returns `dev`. This is caused by Mac OS and Windows building on the host ([logs](https://github.com/oxc-project/oxc/actions/runs/10667173657/job/29564299213#step:6:16)), while Linux is building inside a container. Container builds do not have access to host env variables by default. --- Cross.toml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Cross.toml b/Cross.toml index b6dfa485df895..643e89e206cff 100644 --- a/Cross.toml +++ b/Cross.toml @@ -1,2 +1,6 @@ [build.env] -passthrough = ["CI"] # for crates/oxc_traverse/build.rs +passthrough = [ + "CI", # for crates/oxc_traverse/build.rs + "OXC_VERSION", + "JEMALLOC_SYS_WITH_LG_PAGE", +]