Semantic: ScopeFlags for a class in a class constructor has ScopeFlags::Constructor

[overlookmotel]

Input:

class Outer {
  constructor() {
    class Inner {}
  }
}

Semantic sets ScopeFlags for class Inner {} as StrictMode | Constructor. I believe this is a mistake. It should just be StrictMode.

Weirdly I cannot replicate this in playground (playground). But on latest main, when I print ScopeFlags for all scopes I get this:

ScopeId(0): Program: ScopeFlags(StrictMode | Top)
ScopeId(1): Class(Outer): ScopeFlags(StrictMode)
ScopeId(2): Function(<anonymous>): ScopeFlags(StrictMode | Function | Constructor)
ScopeId(3): Class(Inner): ScopeFlags(StrictMode | Constructor)

Debug code:

let scopes = semantic.scopes();
let nodes = semantic.nodes();
#[allow(clippy::cast_possible_truncation)]
for i in 0..scopes.len() {
    let scope_id = ScopeId::new(i as u32);
    let flags = scopes.get_flags(scope_id);
    let node_id = scopes.get_node_id(scope_id);
    let kind = nodes.get_node(node_id).kind();
    let name = kind.debug_name();
    println!("{scope_id:?}: {name}: {flags:?}");
}

As this isn't visible on playground, is this the result of a very recent change? Or is there something else funny going on?

[overlookmotel]

Fixed in #7932.

[overlookmotel]

@Dunqing @Boshen Do you have any idea why playground showed different ScopeFlags for this example than when run locally?

I thought maybe it was because this problem was created by a recent change, and so Playground just wasn't up-to-date with latest main. But now I don't think that's true. Right now Playground still shows that class Inner does not have Constructor flag, and it must be up-to-date now.

It's a problem for debugging if Playground behaves differently from what we get locally / in production.

[Dunqing]

@Dunqing @Boshen Do you have any idea why playground showed different ScopeFlags for this example than when run locally?

I thought maybe it was because this problem was created by a recent change, and so Playground just wasn't up-to-date with latest main. But now I don't think that's true. Right now Playground still shows that class Inner does not have Constructor flag, and it must be up-to-date now.

It's a problem for debugging if Playground behaves differently from what we get locally / in production.

I found the root cause is #7950