CLEAN UP

Robbepop/modular-bitfield#31
- Says that modular-bitfield now allows deserializing unknown invalid bitpatterns without failure!
  - Getters protect, though.
Compile-time assertions
- const _: () = assert!(std::mem::size_of::<u64>() == 8);
Tokens
- u0x96176308 = is_capsule_mode: bool (fch)
- u0x6c4ccf38 = mem_ps(platform specific)_error_handling: 0~0xff (usually 0); obsolete
- u0xae7f0df4 = bmc_rcb_wrong_attr_dis: 0=en, 1=dis, skip=0xff
FchSmbusSpeed::Auto missing?
Sanity-check MaxFreqElement::new argument 1
define_ErrorOutControl: CHECK DEFAULT VALUES!
RdimmDdr4CadBusElement::new: has address_command_control as one conglomerate--should be split.

Features

Error log should also be readable maybe.
GroupMutIter: Also validate()
IdRevApcbMapping
- id_and_feature_mask: bit 7: 1=user controlled; 0=normal
OdtPatElement: Availability of dimm0_rank, dimm1_rank should be conditional.
Enums for stuff with a "|" comment.
- a lot of platform_specific_override::* enums
  - Cs

Sanity-check non-clone in body_as_struct_mut
Check for unique key on load
- Check globally unique (group_id) on load.
- Check globally unique (group_id, entry_id, instance_id, board_instance_mask) on load.
- Check globally-unique (group_id, instance_id, token_id) on load.
  - insert_token: group_id==Token. entry_id should be datatype-dependent, so only one makes sense per token_id anyway--so entry_id is not part of the unique key.
Fuzzing!
- https://rust-fuzz.github.io/book/cargo-fuzz.html
- Fuzz after:
  - apcb header
  - group header
  - entry header
  - token header

apcb::insert_entry: Replace by shifts and masks (if not compile time)
insert_token: "&" instead of "%"
Check error handling crate "failure" or "anyhow". #[source]
Entry alignment relative to containing group instead??
AMD# 55483 4.1.3 SPD_Info DIMM_INFO_ARRAY does not seem to exist
TX EQ struct; bitfield for sockets; bitfield for dies; bitfield for lanes; lane data (variable-length body!)
Apcb: Dirty-type, original-type; automate calling update_checksum
- My own idea: Just implement Drop and have a flag you refer to.
- Give a reference to the flag to all the iterators that would need to change it
  - If there are &mut to struct that doesn't work, now does it?
insert_struct_sequence_entry(EntryId::Quux).with(A {p : 1}).with(B {q: 42}).finish() (You can do pretty complex construction of structures using that pattern, debug_struct in std is a good example)
- https://doc.rust-lang.org/std/fmt/struct.Formatter.html#method.debug_struct
Move skip_step from EntryCompatible to SequenceElementFromBytes (right now, the latter is only implemented by the enum macro; but skip_step would also be implemented by the enum--but outside the macro. That's too complicated)
Maybe remove "EventControl" id