Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle token datatype changes #121

Open
luqmana opened this issue Feb 14, 2024 · 0 comments
Open

Better handle token datatype changes #121

luqmana opened this issue Feb 14, 2024 · 0 comments

Comments

@luqmana
Copy link
Contributor

luqmana commented Feb 14, 2024

Every token is one of a few types based on its data size: Bool, Byte, Word, Dword. We currently collapse all the defined tokens into a single flat namespace. This does make it a bit annoying if a token gets moved from one to another (e.g. Byte -> Word to accommodate more values in a later version).

One option is to update the codegen to get rid of the flat namespace (#120 (comment)). The json and binary formats already disambiguate the differently sized token entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant