Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from ROM APIs for flash writing #1504

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Move away from ROM APIs for flash writing #1504

merged 1 commit into from
Aug 31, 2023

Conversation

labbott
Copy link
Collaborator

@labbott labbott commented Aug 18, 2023

We have a driver to access the flash controller directly, use it. Remove the old APIs so nobody is tempted to use them.

@flihp
Copy link
Contributor

flihp commented Aug 29, 2023

This work has been rebased on top of main now that #1500 has been merged: https://github.com/flihp/hubris/tree/no_more_rom. I've picked a few minor nits along the way that include mostly cosmetic stuff:

  • adding a 'use drv_lpc55_flash::Flash` instead of spelling out the full type each time it's used in a few spots
  • removing use of lib_lpc55_romapi::FLASH_PAGE_SIZE and replacing it with drv_lpc55_flash::BYTES_PER_FLASH_PAGE
  • making lib_lpc55_romapi::FLASH_PAGE_SIZE private so others aren't tempted to use it instead of the equivalent from drv_lpc55_flash (it's still used by lib_lpc55_romapi internally)

I've also run this code through the identity manufacturing process and it works as expected.

We have a driver to access the flash controller directly, use it. Remove
the old APIs so nobody is tempted to use them.
Copy link
Contributor

@flihp flihp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid

@flihp flihp merged commit cd5f3c4 into master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants