Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiffy-related bits assume enum discriminants are signed, sometimes bytes #471

Open
cbiffle opened this issue Apr 3, 2024 · 0 comments
Open
Labels
🐛 bug Something that isn't working.

Comments

@cbiffle
Copy link
Contributor

cbiffle commented Apr 3, 2024

This is a follow-on for #468. In #469 I fixed the cases where enums were being read from target memory (or memory images), but that's not every case where we do enum parsing.

There are several cases in Hiffy-related commands like rpc where we "parse" enums from data returned in an array of u32s. I didn't go ahead and fix these, because there's some cross-system shenanigans happening there that obscure whether the data is being e.g. zero-extended. Instead, I slapped TODOs on them.

At the time of this writing the affected crates were

  • cmd/rpc
  • cmd/validate
  • humility-idol
  • humility-hiffy
@cbiffle cbiffle added the 🐛 bug Something that isn't working. label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something that isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant