-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add codespell linter #4143
base: main
Are you sure you want to change the base?
Conversation
f69ce60
to
f2c2fa3
Compare
f2c2fa3
to
04dd611
Compare
04dd611
to
0577625
Compare
0577625
to
41077c0
Compare
@nvuillam The PR I created is failing for reasons that are not obvious to me. I will hopefully get around to take another look tomorrow. Hints welcome. |
@@ -211,3 +211,39 @@ linters: | |||
dockerfile: | |||
- FROM lycheeverse/lychee:latest-alpine AS lychee | |||
- COPY --link --from=lychee /usr/local/bin/lychee /usr/bin/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quality :)
6f40e6d
to
4a72ed8
Compare
@nvuillam It looks to me like the Tests + Deploy Docker Image - DEV check failed for reasons unrelated to the PR. I don't see why shfmt and markdown-link-check should fail. The MegaLinter failed because cspell finds misspelled words in the I am not sure whether I should add the words in I can implement changes, but I need some guidance on how to proceed to match the project's expectations. |
@ideaship you can disable codespell on MegaLinter on linting :) |
4a72ed8
to
10fa638
Compare
10fa638
to
4fe6935
Compare
4fe6935
to
588abc0
Compare
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words. Signed-off-by: Roger Luethi <[email protected]>
588abc0
to
9b79aaa
Compare
@nvuillam I disabled the errors for codespell as you suggested. What remains are the v8r errors. I don't see how the changes I made would cause the errors v8r reports. |
Hmm strange, i'll have a look :) |
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.
Fixes #4140
Proposed Changes
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance