Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oxygenEntitiesDictionary.dita #32

Open
mbakeranalecta opened this issue Aug 13, 2014 · 1 comment
Open

oxygenEntitiesDictionary.dita #32

mbakeranalecta opened this issue Aug 13, 2014 · 1 comment

Comments

@mbakeranalecta
Copy link
Contributor

I think we should be turning the contents of oxygenEntitiesDictionary.dita into keys. Having two different ways of entering variables for content is confusing to authors, and entering them as keys is simpler, more portable, and creates more compact source files. It will also be easier to maintain all variables in one place using one method. (currently, some of the entities are defined by keys, which is unnecessary redirection and creates two different ways to enter the same variable.)

I also notice that some of the entries in oxygenEntitiesDictionary.dita are out of date. Specifically:

  <ph id="editorMajorVersion">14</ph>
  <ph id="editorMinorVersion">14.2</ph>
  <ph id="editorEclipseMinorVersion">14.2.0</ph>

editorMajorVersion is not used in the content, but editorMinorVersion is (\topics\scroll-function-not-working-on-notebook.dita)

This makes me nervous about all the other version numbers in this file.

@raducoravu
Copy link
Contributor

Indeed we should first remove the unused stuff from it. It is not used anymore probably because there are already keys defined in the DITA Map which define those as keywords.
And the used stuff probably as you say replaced by keydefs in the main dita map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants