PHP 7.3 Compat: Continue Targeting Switch issues Warning

[trepmal]

Hi,

I was scanning a different codebase for PHP 7.3, and came across these:

less.php/lib/Less/Exception/Chunk.php

Line 70 in 42925c5

continue;

less.php/lib/Less/Exception/Chunk.php

Line 78 in 42925c5

continue;

less.php/lib/Less/Exception/Chunk.php

Line 83 in 42925c5

continue;

less.php/lib/Less/Exception/Chunk.php

Line 89 in 42925c5

continue;

less.php/lib/Less/Exception/Chunk.php

Line 99 in 42925c5

continue;

less.php/lib/Less/Exception/Chunk.php

Line 102 in 42925c5

if ($this->parserCurrentIndex < $this->input_len - 1) { $this->parserCurrentIndex++; continue; }

less.php/lib/Less/Exception/Chunk.php

Line 122 in 42925c5

if ($matched) { continue; }

less.php/lib/Less/Exception/Chunk.php

Line 127 in 42925c5

if ($parenLevel || ($this->parserCurrentIndex == $this->input_len - 1)) { continue; }

less.php/lib/Less/Exception/Chunk.php

Line 148 in 42925c5

continue;

less.php/lib/Less/Exception/Chunk.php

Line 155 in 42925c5

continue;

continue statements targeting switch control flow structures will now generate a warning. In PHP such continue statements are equivalent to break, while they behave as continue 2 in other languages.

http://php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.continue-targeting-switch

At a glance, it looks like these can be changed to break, but I'll admit I haven't tested this case.

[trepmal]

Ah, I missed the abandonment notice in #371

For those stumbling across this, it's fixed in the fork Asenar@b56f7bb#diff-cd3ec84e97521abdea4b5c455448c3b9