-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burrow is now exposing API v3 which is not compatible with API v2. #7
Comments
Looks like there are many forks with v3 API support https://github.com/packetloop/datadog-agent-burrow/network. |
@Johnny-Malizia maybe you will make PR? |
JFYI we use this fork now https://github.com/amura2406/datadog-agent-burrow/ and all seems fine |
Unfortunately I don't have access to this repo any longer so I can't merge any PR's. @lenfree do you folks still use this datadog-agent? It looks like Burrow has moved ahead a fair bit now and this agent is woefully behind. |
Our forked burrow repo has diverged from upstream due to some bugfixes and PR wasn't merged from several months ago. Hence, we decided to replace this with something simpler instead although this bit is still in our backlog with high priority. I will however update README as soon as I have more information. |
I tried this but the burrow is not providing the accurate data for consumer_lag. But it's worth a try.
This burrow-check doesn't provide data after 3 mins. |
Are you planning on making your fork public? If not, what was your simple solution you mentioned about? |
@jomendoz at the moment, Burrow replacement ticket is still in our backlog and we plan to open source this once we start this work. There was a bug many months ago about missing data and PR (quick fix) to upstream codebase has yet to be reviewed/merged. Hence, we plan to rewrite this and just provide metrics/data we need instead of all features Burrow have. Since, we're kind of stuck with Burrow and Kafka v2, I am unable to work on v3. However, I am open to review any PRs made for v3 and we could perhaps tag current version to v2 branch and promote v3 PR to master branch. |
@lenfree Thanks for replying. At the end, we sorted out on keeping using Kafka Manager for offsets collection and I added a custom checks configuration upon Datadog agent to read from the API. |
amura2406/datadog-agent-burrow works well, but I added python3 and last DD agent changes support: |
This makes the check not working.
The text was updated successfully, but these errors were encountered: