Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrow is now exposing API v3 which is not compatible with API v2. #7

Open
sa-mao opened this issue Feb 12, 2018 · 11 comments
Open

Burrow is now exposing API v3 which is not compatible with API v2. #7

sa-mao opened this issue Feb 12, 2018 · 11 comments

Comments

@sa-mao
Copy link

sa-mao commented Feb 12, 2018

This makes the check not working.

@xkrt
Copy link

xkrt commented Mar 20, 2018

Looks like there are many forks with v3 API support https://github.com/packetloop/datadog-agent-burrow/network.
Does anybody try them? What fork production-ready?

@echo-xu
Copy link

echo-xu commented Jun 20, 2018

@xkrt
Copy link

xkrt commented Jun 21, 2018

@Johnny-Malizia maybe you will make PR?

@xkrt
Copy link

xkrt commented Sep 19, 2018

JFYI we use this fork now https://github.com/amura2406/datadog-agent-burrow/ and all seems fine

@jgmchan
Copy link
Contributor

jgmchan commented Sep 19, 2018

Unfortunately I don't have access to this repo any longer so I can't merge any PR's. @lenfree do you folks still use this datadog-agent? It looks like Burrow has moved ahead a fair bit now and this agent is woefully behind.

@lenfree
Copy link
Contributor

lenfree commented Sep 20, 2018

Our forked burrow repo has diverged from upstream due to some bugfixes and PR wasn't merged from several months ago. Hence, we decided to replace this with something simpler instead although this bit is still in our backlog with high priority. I will however update README as soon as I have more information.

@nutanix-bigbasket
Copy link

nutanix-bigbasket commented Jul 20, 2019

You can try: https://github.com/Johnny-Malizia/datadog-agent-burrow/tree/v3

I tried this but the burrow is not providing the accurate data for consumer_lag. But it's worth a try.

JFYI we use this fork now https://github.com/amura2406/datadog-agent-burrow/ and all seems fine

This burrow-check doesn't provide data after 3 mins.

@joshuamzm
Copy link

@lenfree

Are you planning on making your fork public?

If not, what was your simple solution you mentioned about?

@lenfree
Copy link
Contributor

lenfree commented Aug 28, 2019

@jomendoz at the moment, Burrow replacement ticket is still in our backlog and we plan to open source this once we start this work. There was a bug many months ago about missing data and PR (quick fix) to upstream codebase has yet to be reviewed/merged. Hence, we plan to rewrite this and just provide metrics/data we need instead of all features Burrow have. Since, we're kind of stuck with Burrow and Kafka v2, I am unable to work on v3. However, I am open to review any PRs made for v3 and we could perhaps tag current version to v2 branch and promote v3 PR to master branch.

@joshuamzm
Copy link

@lenfree Thanks for replying.

At the end, we sorted out on keeping using Kafka Manager for offsets collection and I added a custom checks configuration upon Datadog agent to read from the API.

@rainchik
Copy link

amura2406/datadog-agent-burrow works well, but I added python3 and last DD agent changes support:
https://github.com/rainchik/datadog-agent-burrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants