Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact authorization header contents from logged warnings when running provider verification #119

Open
canny bot opened this issue Jun 26, 2024 · 1 comment

Comments

@canny
Copy link

canny bot commented Jun 26, 2024

Currently when you use pact-provider-verifier ... --custom-provider-header="Authorization: xxx" to give, for example, a bearer token to Pact while running the provider verifications. The contents of the header get printed out in plain text as a warning:
WARN: Adding header 'Authorization: Bearer <visible value>'

It would be nice if these contents could be redacted for the Authorization header and instead it would print something like:
WARN: Adding header 'Authorization: [REDACTED]'

Even though we're talking about dev/test deployment related secrets, it still isn't very nice to expose them in a visible manner. Of course an easy workaround is to simply perform an inverted grep for discarding all lines that begin as the mentioned warning. But it would be nice to have this functionality built-in.

https://pact.canny.io/admin/board/feature-requests/p/redact-authorization-header-contents-from-logged-warnings-when-running-provider

Copy link
Author

canny bot commented Jun 26, 2024

This issue has been linked to a Canny post: Redact authorization header contents from logged warnings when running provider verification 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants