Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust verifier and stub server to image #95

Open
mefellows opened this issue Mar 22, 2023 · 1 comment
Open

Add rust verifier and stub server to image #95

mefellows opened this issue Mar 22, 2023 · 1 comment

Comments

@mefellows
Copy link
Member

So technically this is the Ruby project, but this creates our official CLI image. This creates a confusing experience for users "which version are you using, the Ruby one or the new Rust one" to which we are met with understandable confusion.

I wonder if we should consider adding the rust verifier and stub service to our CLI packaging (perhaps also the standalone project?) and improving how we make CLIs available to our audience.

Slack thread that triggered the discussion: https://pact-foundation.slack.com/archives/C5F4KFKR8/p1679427692760169

The user actually needed (and thought they were using the verifier that supports v4) https://docs.pact.io/implementation_guides/cli#native-binary-new but actually was using the Ruby one.

@YOU54F
Copy link
Member

YOU54F commented Apr 26, 2023

If size isn't an issue, I'm happy adding all the things.

However, we may want a rust core backed image (with mock server/verifier), ruby core backed image (with mock server/verifier)

and then an image that is for non rust/ruby things, like the pact broker client (its in ruby, but is just for communicating with the broker)

being clear about the mock consumer and mock provider, that there are essentially two other these, one set in rust/one set in ruby

separating those tools out and presenting them in a clear way.

if the rust backed verifier is backwards compliant with 2.0 specs, is there any need for the ruby verifier to hang around as a recommend option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants