Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify PACT_PROVIDER env variable #133

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: simplify PACT_PROVIDER env variable #133

merged 2 commits into from
Oct 17, 2023

Conversation

tuan-pham
Copy link
Contributor

@tuan-pham tuan-pham commented Oct 17, 2023 •
edited
Loading

The build was broken here due to the reference to env. As suggested by Yousaf, I will replace matrix.pact_provider with env.PACT_PROVIDER

@tuan-pham tuan-pham requested review from mefellows and YOU54F October 17, 2023 00:50
@tuan-pham tuan-pham changed the title fix: revert build yml file to use secrets to fix the build fix: simplify PACT_PROVIDER env variable Oct 17, 2023
@mefellows mefellows merged commit 5cfd654 into master Oct 17, 2023
3 checks passed
@mefellows mefellows deleted the fix-broken-build-due-to-env-var branch October 17, 2023 04:16
@YOU54F
Copy link
Member

YOU54F commented Oct 17, 2023

Thanks @tuan-pham - we can actually remove the PACT_PROVIDER env being set in the individual steps on line 27 and below

https://github.com/pactflow/example-consumer/pull/133/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R27

as its now set at the top level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mefellows mefellows Awaiting requested review from mefellows

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuan-pham @YOU54F @mefellows