Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix routing graph construction and calculation of shortest route #87

Closed
wants to merge 3 commits into from

Conversation

markomiz
Copy link

@markomiz markomiz commented Nov 9, 2023

fixes the issue #77 :

#77

Changes:

  • added operators == and != to lanekeys
  • reimplemented get_routing_graph (using existing junction parsing)
  • reimplemented shortest_path

@pageldev
Copy link
Owner

Looks good. Maybe @Novadgaf can confirm that this fixes his issue?

Also can you run some tests on the default data.xodr odrviewer.io uses? Ideally running your routing on some start/end combinations and checking if they are correct / as expected.

@markomiz
Copy link
Author

@pageldev I've tested on many carla maps now and some other maps I have access to - it is working reliably now. One thing that could be improved in the future however is allowing lane changes to neighbouring lanes as part of the routing which isn't currently possible.

@markomiz markomiz closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants