Make usage of <code> in headers *not* ugly #34
Conversation
0.875 is 14/16 (16px being the default font size specified in the rule for <body>). This way usage of <code> elements will not be ugly since the font size will be relatively scaled (e.g. 28px instead of 14px for <h2> with default size 32px).
|
Welcome! Congrats on your first pull request to The Slate Theme. If you haven't already, please be sure to check out the contributing guidelines. |
|
before: after ( |
|
Congrats on getting your first pull request to The Slate Theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
|
The problem continues. |
0.688is 11/16 (16px being the default font size specified in the rule for <body>). This way usage of <code> elements will not be ugly since the font size will be relatively scaled (e.g. 28px instead of 14px for <h2> with default size 32px). Explained here: pages-themes#34 Example of ugliness: https://toughengineer.github.io/talks/C++%20Siberia%202020/
|
@abdullahkavakli, it is not fixed on GitHub Pages because the new version in this repo is not deployed to GitHub pages instance or something like that. |
|
@toughengineer didn't benbalter merged this commit into pages-themes:master ? I couldn't understand. Can u explain more please? |
|
@abdullahkavakli, my understanding is that the change is indeed in the master branch, but the code with the change is not yet delivered to GitHub pages itself, i.e. it seems that repos in pages-themes project are separate from what actual GitHub pages use, and changes from repos are not automatically delivered to GitHub pages. |
|
I got now what u mean. Can i ask another question? My commits can't pass travis test. Like this: #58 Do u know why? |
|
@abdullahkavakli, no idea. |
0.875 is 14/16 (16px being the default font size specified in the rule for <body>).
This way usage of <code> elements will not be ugly since the font size will be relatively scaled (e.g. 28px instead of 14px for <h2> with default size 32px).
Example of ugliness:
https://toughengineer.github.io/talks/C++%20Siberia%202020/