Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diversity curve generator only uses the collections in the map view to plot diversity. This is NOT obvious nor apparent. #101

Closed
markuhen opened this issue Mar 2, 2018 · 5 comments
Assignees

Comments

@markuhen
Copy link

markuhen commented Mar 2, 2018

No description provided.

@markuhen
Copy link
Author

markuhen commented Mar 2, 2018

I think we need to change the entire Navigator system to count everything that matches the search parameters globally all the time. We should NOT change the count of the collections and occurrences as you zoom in the map. This is proving to be VERY confusing to end users. This should simplify the code behind Navigator and the Diversity Curve generator. The Navigator count code is malfunctioning anyway, see #98.

@vjpsyverson
Copy link
Member

I think the best solution to this overall would be to stop filtering by screen extent and add a feature that allows the user to draw a bounding box manually. I'm picturing it as a tool that you would select from the bar, drag over the desired region to highlight it (i.e. gray out the rest of the map), and then you could zoom independent of the bounding box. It could then be given as a filter option in the filter box in the lower left corner as "(0.00 N, 0.00 E) x (1.00 N, 1.00 E)" and deleted the same way the other filters are.

Until that's implemented, though, we don't have any way to geographically restrict other than by screen extent. Would it be better not to do it at all than to do it the way we currently do, @markuhen?

@mmcclenn
Copy link
Contributor

Unfortunately, this change has still not been made. I have been focusing on data entry, and haven't had time to delve into the Navigator code. I didn't write that code, and would have to take some time to figure it out before I can make any substantive changes to it. I would love to do a thorough overhaul of Navigator, if we can find some funding somewhere to do that.

@markuhen
Copy link
Author

I think for now we just need to make it super clear on the diversity curve screen that it is plotting what was on the Navigator screen. That should suffice for now.

@vjpsyverson
Copy link
Member

I've added a simple fix for this: it now just displays the lat/long values it's sending to quickdiv at the top right of the diversity modal. The awesome potential improvement discussed above has been moved to #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants