Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG (string dtype): replace with non-string to fall back to object dtype #60285

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Nov 12, 2024

xref #54792

@jorisvandenbossche jorisvandenbossche added Bug Strings String extension data type and string data replace replace method labels Nov 12, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 12, 2024
@jorisvandenbossche jorisvandenbossche merged commit 938832b into pandas-dev:main Nov 12, 2024
51 checks passed
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-replace-object-upcast branch November 12, 2024 21:41
Copy link

lumberbot-app bot commented Nov 12, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 938832ba325c6efc1710e002c0d3d4d9b3a6c8ba
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60285: BUG (string dtype): replace with non-string to fall back to object dtype'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60285-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60285 on branch 2.3.x (BUG (string dtype): replace with non-string to fall back to object dtype)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60292

mroeschke pushed a commit that referenced this pull request Nov 14, 2024
…back to object dtype (#60285) (#60292)

* BUG (string dtype): replace with non-string to fall back to object dtype (#60285)

Co-authored-by: Matthew Roeschke <[email protected]>
(cherry picked from commit 938832b)

* updates for 2.3

* fix inplace modification for 2.3.x branch with python storage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug replace replace method Strings String extension data type and string data
Projects
None yet
2 participants