Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST (string dtype): resolve xfails in pandas/tests/apply + raise TypeError for ArrowArray accumulate #60312

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

jorisvandenbossche
Copy link
Member

Resolve all remaining string xfails in pandas/tests/apply, except for one about cumsum not yet implemented for string dtype.

Also ensures we don't raise a pyarrow specific error in case of the pyarrow-backend for accumulation methods.

xref #54792

@jorisvandenbossche jorisvandenbossche added the Strings String extension data type and string data label Nov 14, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 14, 2024
@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review November 14, 2024 12:32
@WillAyd WillAyd merged commit fba5f08 into pandas-dev:main Nov 15, 2024
51 checks passed
Copy link

lumberbot-app bot commented Nov 15, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 fba5f08f048215a6e0a578f8bad7b7f2c9ee8eef
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60312: TST (string dtype): resolve xfails in pandas/tests/apply + raise TypeError for ArrowArray accumulate'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60312-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60312 on branch 2.3.x (TST (string dtype): resolve xfails in pandas/tests/apply + raise TypeError for ArrowArray accumulate)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@WillAyd
Copy link
Member

WillAyd commented Nov 15, 2024

Since you've got a ton going on I'm happy to take care of this backport

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Nov 15, 2024
…olve xfails in pandas/tests/apply + raise TypeError for ArrowArray accumulate)

(cherry picked from commit fba5f08)
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-tests-apply branch November 15, 2024 19:56
@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60328

mroeschke pushed a commit that referenced this pull request Nov 15, 2024
…s in pandas/tests/apply + raise TypeError for ArrowArray accumulate) (#60328)

* Backport PR #60312 on branch 2.3.x (TST (string dtype): resolve xfails in pandas/tests/apply + raise TypeError for ArrowArray accumulate)

(cherry picked from commit fba5f08)

* 2.3 test function compat

---------

Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants