Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Copy attrs on pd.merge() #60357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Copy attrs on pd.merge() #60357

wants to merge 1 commit into from
+47 −14

Commits on Nov 19, 2024

  1. BUG: Copy attrs on pd.merge() 

    This uses the same logic as `pd.concat()`: Copy `attrs` only if all
input `attrs` are identical.

I've refactored the handling in __finalize__ from special-casing based on th the method name (previously only "concat") to handling "other" parameters
that have an `input_objs` attribute. This is a more scalable architecture compared to hard-coding method names in __finalize__.

Tests added for `concat()` and `merge()`.

Closes pandas-dev#60351.
    @timhoffm
    timhoffm committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7815e73 View commit details
    Browse the repository at this point in the history