Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff stats not refreshing until dashboard is viewed in browser #145

Open
cboyden opened this issue May 30, 2014 · 2 comments
Open

Diff stats not refreshing until dashboard is viewed in browser #145

cboyden opened this issue May 30, 2014 · 2 comments
Labels

Comments

@cboyden
Copy link

cboyden commented May 30, 2014

Intermittently, code changes that are made in SFTP mode aren't showing up in the Terminus diff stats. Terminus does not know the code has changed until you visit the dashboard in the browser, which sort of defeats the point.

Here's a recent example:

...
$ drush psite-commit $SITE dev --message=Contrib module updates
No changes found to commit, aborting.                                           [error]
$ drush psite-diffs $SITE dev
No diffs found.                                                                 [ok]
$ drush psite-diffs $SITE dev
No diffs found.                                                                 [ok]
$ drush psite-dash $SITE -y
https://dashboard.getpantheon.com/sites/a90383ba-33cf-4495-b1d0-c37a78f05c31
Would you like to open this link now? (y/n): y
$ drush psite-diffs $SITE dev
 File  Deletions  Additions
 profiles/panopoly/modules/contrib/nice_menus/js/jquery.hoverIntent.js
 ...

This is not simply a question of timing. Yesterday I let some changes sit for almost an hour and still got "No diffs found" until I loaded the dashboard.

If you can't get up-to-date diffs by running psite-diffs, you're in more danger of blowing away changes if you switch back to Git.

@mikevanwinkle
Copy link
Contributor

Hey @cboyden, I can replicate this behavior and have labeled it a bug. This one may not be a bug with terminus however, rather a bug in our api so I'll have to dig deeper and possibly consult a platform dev. Thanks for your patience.

@joshkoenig
Copy link
Contributor

It's a little of both. Diffs are generated on-demand via a process that is triggered in the dashboard. We can/should refresh diffs whenever they are requested. Need to figure out how to kick/trigger the "watcher" process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants