Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psite-dl-backup destination param should handle absolute file paths #146

Open
donutdan4114 opened this issue Jun 9, 2014 · 2 comments
Open

Comments

@donutdan4114
Copy link

Currently, using psite-dl-backup, the destination parameter only works when specifying a directory. You cannot specify an output filename. This means that every time you download the backup, it will have a new name (unpredictable).
> drush psite-dl-backup $SITE_NAME dev latest database ./destination

If the command returned/output the filename of the file downloaded, that'd be a good start.

Suggested fix: if destination parameter is a file name (includes a ".") the file should be saved with that name. Or perhaps you can add a flag, for marking something as a file.
> drush psite-dl-backup $SITE_NAME dev latest database ./my-backup.sql

OR, if no destination param, output the file using stdout for more control
> drush psite-dl-backup $SITE_NAME dev latest database > ./my-backup.sql

@joshkoenig
Copy link
Contributor

Seems legit. I believe all that would be required is allowing the user to pass a specific value here:

https://github.com/pantheon-systems/terminus/blob/master/terminus.drush.inc#L2099

Pull requests welcome, otherwise we'll get to it in an upcoming sprint.

@mikevanwinkle
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants