Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for meaningful terminus auth login failure message #182

Open
jbutkus opened this issue Oct 3, 2014 · 6 comments
Open

Request for meaningful terminus auth login failure message #182

jbutkus opened this issue Oct 3, 2014 · 6 comments

Comments

@jbutkus
Copy link

jbutkus commented Oct 3, 2014

When terminus auth login fails it just outputs "Error: Authentication failed. Please check your credentials and try again.".

In some cases I know it's not true, because we use a script to do the deployments, which has a configuration file with password, and that one doesn't change.

Please add a meaningful authorization message, like /Server is overloaded. Please retry in (\d) seconds./. I provide a regexp-like message, as we would be parsing it and using response as a guideline.

@mikevanwinkle
Copy link
Contributor

Yes, I think it's reasonable to add a message here based on the http status so that a server busy 504 is not mistaken for a failed authentication. Looking at the code, this message is returned whenever the session cookie is not present, but that clearly doesn't account for all possibilities. Thanks for pointing this out. Will try to get it in eventually.

@joshkoenig
Copy link
Contributor

@mikevanwinkle I think the best answer is to upgrade to our "real" login functionality that will let us ditch the whole cookie/scrape thing. Let's discuss this week.

@JeffreyWilcox-zz
Copy link

Hey guys, any update on this one? It's giving us some grief...

@mikevanwinkle
Copy link
Contributor

So Terminus 2.0 will have abetter login experience. But it's still weeks out from code parity with this version. You can track progress here: https://github.com/pantheon-systems/cli/tree/develop

@JeffreyWilcox-zz
Copy link

OK we will just keep mashing the "update all" button for now :)

@joshkoenig
Copy link
Contributor

Hey @jeffreywilcox / @jbutkus I believe we also have a specific support thread open with you guys to debug the login issue you are having specifically.

While giving you better error messages would be good, even better would be preventing your logins from timing out. My guess is there's something inefficient on our end that's occasionally getting hung up because of the large volume of sites that you have in your account; we should be able to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants