psite-service-level doesn't seem to work with 1000+ sites

[jbutkus]

We have 1000+ sites in our Dashboard.

When we try to crete new site it spins up and responds (HTTP request shows site installed). Before proceeding with set-up we try to change site level to appropriate one:

drush pantheon-site-service-level $SITE_UUID basic

While expected output is Service level changed we actually get a list of sites numbered from \[0\] to \[999\] and a prompt "Select a site".

We cannot do that, because:

• we are running this in automated environment, where interactive responses are not expected;
• the site is not in that list, because it's newly created and, likely, it's further down the list.

Can we increase this limit of 1000 sites somehow?
And potentially - avoid having to answer interactive question in automated script.

[mikevanwinkle]

@jbutkus So I'm unclear of why you think there's a limit of 1000 ... 0 - 999 is 1000 so I suspect this is just coincidence. However, I think that the massive list you received is expected behavior if the UUID is incorrect or not provided. Did you try drush cc all before running the command? If not can you give it a try and then run the service level upgrade again?

[joshkoenig]

The output you describe occurs if you provide a UUID that Terminus cannot find. It is attempting to validate the UUID you are providing and failing.

The magic number of 1000 is suspicious. I believe there may be a default list limit on the API side but we'll need to check. This is not specifically a Terminus issue, but we can probably improve validation logic.

[jbutkus]

This is replicable.

You need two accounts in the same organisation:

• one owning 2000 sites (d90ef09a-961e-499f-a985-6e072fafedc0);
• the other owning some 5 sites (c2df5ed7-6dff-4c4b-a6fc-4e9cc6a15db9).

Try the following process (clean cache before any attempt) with each of these accounts:

• create new site using drush pantheon-site-create - this is likely to succeed (though reporting Reporting from long running commands #190 might not be obvious);
• give site some time to spin up; i.e. inspect what's rendered;
• attempt to execute drush pantheon-site-service-level - this will fail with organisation owning >=2000 sites and succeed with the one owning <=10.

The user accounts are actual ones. The operations were tried just a minutes apart. And it was reproducible for a test of over 10 site spin-ups.