Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate documentation: Terminus does does not support php version 8.3+ but Pantheons documentation states it does. #8831

Closed
zane-kanopi opened this issue Jan 18, 2024 · 3 comments
Assignees
Labels
Type: Fix Content Issue or PR to resolve incorrect information in the docs Type: Quick Fix Issues that should be resolvable in a small PR

Comments

@zane-kanopi
Copy link

zane-kanopi commented Jan 18, 2024

https://docs.pantheon.io/terminus/install

Expected behavior

  • Terminus works: terminus --version displays the version.

Actual behavior

$ terminus --version

PHP 8.3+ is not supported by this version of Terminus.
Check for new versions at https://github.com/pantheon-systems/terminus/releases

Set environment variable TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP to try continuing anyway.
Stopping.

Steps to reproduce the problem

  1. Run the above commands.

Suggested Resolution

  • Update documentation to note 8.3 is not supported.

Current docs state:

PHP Version 7.4 or later
reference: https://docs.pantheon.io/terminus/install#required-packages

Screenshot 2024-01-18 at 11 52 58 AM
@zane-kanopi zane-kanopi added the Type: Fix Content Issue or PR to resolve incorrect information in the docs label Jan 18, 2024
@damienmckenna
Copy link
Contributor

Should this be moved to the Terminus issue queue, or the issue title updated to clarify it's about Terminus and not Pantheon hosting itself?

@zane-kanopi
Copy link
Author

zane-kanopi commented Jan 24, 2024

Should this be moved to the Terminus issue queue, or the issue title updated to clarify it's about Terminus and not Pantheon hosting itself?

@damienmckenna specifically this is about Pantheons hosting documentation (hence its on the Pantheon Systems Documentation repo) on regarding their Terminus product.

I've updated the description to better reflect a solution that only involves updating documentation along with updating the description to show this is in reference to the documentation.

@zane-kanopi zane-kanopi changed the title Does not support php version 8.3 Inaccurate documentation: Terminus does does not support php version 8.3+ but Pantheons documentation states it does. Jan 24, 2024
@stevector stevector added the Type: Quick Fix Issues that should be resolvable in a small PR label Jul 10, 2024
@stevector stevector self-assigned this Jul 10, 2024
@stevector
Copy link
Contributor

It looks like this issue was fixed here: https://github.com/pantheon-systems/terminus/pull/2517/files

On my local machine I'm seeing:

terminus --version

Terminus 3.3.5

and

 php -v
PHP 8.3.4 (cli) (built: Mar 12 2024 23:42:26) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.4, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.4, Copyright (c), by Zend Technologies

Please re-open if there's still a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix Content Issue or PR to resolve incorrect information in the docs Type: Quick Fix Issues that should be resolvable in a small PR
Projects
None yet
Development

No branches or pull requests

3 participants