Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Use dev-develop until 10.0 is released #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pwtyler
Copy link
Member

@pwtyler pwtyler commented Dec 13, 2024

PHPCompatibility/PHPCompatibility 9.3 does not include any PHP 8 checks, so the value of this action is limited unless the dev branch is used. Instead, defaulting the action to use the development branch of PHPCompatibility until version 10 is released.

Fixes #8.

c/f
PHPCompatibility/PHPCompatibility#1284
PHPCompatibility/PHPCompatibility#1306

@pwtyler pwtyler requested a review from a team as a code owner December 13, 2024 21:18
Copy link

Composer Changes
Prod Packages Operation Base Target
phpcompatibility/php-compatibility Changed 9.3.5 dev-develop 02835e4
phpcsstandards/phpcsutils New - 1.0.12
squizlabs/php_codesniffer Upgraded 3.11.1 3.11.2

@kporras07
Copy link
Collaborator

I approved but maybe make it clear in README (?)

@pwtyler
Copy link
Member Author

pwtyler commented Dec 16, 2024

I approved but maybe make it clear in README (?)

Ah yes good call, I realized i need to do that end of day Friday then forgot when I started looking at things today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 8.x checks a parameter of the action
3 participants