Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close and open a new PR if a Release PR exists for a smaller version number bump #14

Open
pwtyler opened this issue Jun 6, 2023 · 0 comments

Comments

@pwtyler
Copy link
Member

pwtyler commented Jun 6, 2023

From CONTRIBUTING.MD

if a feature constitutes a minor or major version bump, that version update should be discussed and made as part of approving and merging the feature into main.

Today, if a PR is merged to main with a larger version bump that a previously drafted release (i.e. release-1.2.1 exists and then with a new feature we create release-1.3.0), we would end up with two draft release PRs.

Automation should instead close the previous release as part of creating a new one.


The most trivial way I can think of way to do this would be to have a release pr tag that is applied adjacent to the existing automation tag. release-pr.sh would close any open PR with that tag with a link to the newly-created one. c/f https://gist.github.com/pwtyler/275e5518cee4882eaf3d529edd3f3bda for prior art creating and then closing PRs, although I think this case will be simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant