Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.13 complete-platforms for AWS Lambda #21656

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Python 3.13 complete-platforms for AWS Lambda #21656

wants to merge 2 commits into from

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Nov 17, 2024 •
edited
Loading

Lambda now supports Python 3.13 (https://aws.amazon.com/about-aws/whats-new/2024/11/aws-lambda-support-python-313), so this adds the relevant complete-platforms.

@huonw huonw marked this pull request as ready for review November 17, 2024 23:35
krishnan-chandra
krishnan-chandra approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@krishnan-chandra krishnan-chandra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for staying on top of this!

Re: your comment

Note that Pants itself may not yet have great 3.13 support (#20852), but that doesn't block ticking this box.

Hasn't the linked issue already been fixed in #21389 and #21400?

@huonw
Copy link
Contributor Author

huonw commented Nov 17, 2024 •
edited
Loading

Hasn't the linked issue already been fixed in #21389 and #21400?

Good catch! I was just going off the issue, I've tested and closed #20852 now and deleted that irrelevant sentence.

@krishnan-chandra
Copy link
Contributor

Awesome. On a similar note I think we can close #21103 as well, which addresses a related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnan-chandra krishnan-chandra krishnan-chandra approved these changes

@benjyw benjyw Awaiting requested review from benjyw

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huonw @krishnan-chandra