Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switch-global-* actions #775

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Added switch-global-* actions #775

merged 12 commits into from
Feb 8, 2024

Conversation

dawsers
Copy link
Collaborator

@dawsers dawsers commented Feb 7, 2024

This pull request is to add four new actions that complement switch-right, switch-left, switch-up and switch-down with global versions that change window regardless of monitor boundaries. This means the action will not respect the current monitor boundaries and will select a window on the adjacent monitor if the previous selection was at a boundary. For example, switch-global-right when the selected window is the rightmost of a space will move to the monitor on the right and select the first window. While within monitor boundaries, the behavior is exactly the same as switch-*.

  1. It doesn't change other actions, you can always keep on changing monitors with <Super><Shift><right/left/up/down>, which preserves the last selected window on each space when moving back and forth, while switch-global-* actions don't (they move to the "closest" window).
  2. There are no default key bindings for these actions. For example, I have replaced the ones for switch-* with the actions switch-global-*, but by default, the change doesn't do anything.

The pull request is backwards compatible, transparent, and needs the user to enable the behavior knowingly; it doesn't add any key bindings by default.

@jtaala jtaala changed the base branch from release to develop February 7, 2024 22:04
@jtaala
Copy link
Collaborator

jtaala commented Feb 7, 2024

Thanks for the PR @dawsers!

Looks okay to me. I'll give this a test soon.

Note: I changed the branch to develop since we don't accept PRs directly into release branch.

@jtaala
Copy link
Collaborator

jtaala commented Feb 7, 2024

@kassick looks like the rebase-pr action failed here. Weirdly, looks like a CORS issue trying to add a comment - not sure what's going on there. I just changed it to develop branch manually.

@jtaala
Copy link
Collaborator

jtaala commented Feb 8, 2024

Hey @dawsers. Looks good. I've just implemented fluid minimap/navigation across monitors (i.e. the minimap jumps to the other monitor - feels better and more natural here). Also applied paperwm linter (which just fixed up some things re style/formatting).

@jtaala jtaala self-requested a review February 8, 2024 11:05
Copy link
Collaborator

@jtaala jtaala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels good. I like this approach - glad you thought of it!

@jtaala
Copy link
Collaborator

jtaala commented Feb 8, 2024

@dawsers - see #723 (comment)

Given your contribution, if you have a donation link to accept donations (e.g. buymeacoffee.com etc) let me know and I'll add for the next release.

@dawsers
Copy link
Collaborator Author

dawsers commented Feb 8, 2024

Thank you so much for cleaning it up and adding it!

There is no need to add me to donations or anything. I have been using PaperWM just for a few days (moved from QTile), and I really like it, so I am very grateful to you guys.

I guess this PR can be closed.

@jtaala
Copy link
Collaborator

jtaala commented Feb 8, 2024

I'll merge this into develop and add this to the next release (which I'll likely do in the next few days). Thanks for contributing @dawsers!

@jtaala jtaala merged commit 1cc567e into paperwm:develop Feb 8, 2024
@Thesola10
Copy link
Collaborator

@kassick looks like the rebase-pr action failed here. Weirdly, looks like a CORS issue trying to add a comment - not sure what's going on there. I just changed it to develop branch manually.

may have something to do with permissions somehow? maybe due to committer not being a trusted contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants