-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commands switch-(up/down)-or-else-workspace #850
Add commands switch-(up/down)-or-else-workspace #850
Conversation
Add commands to switch to the window above (or below), but fall back to switching to the workspace above (or below) if there was no window above (or below). Keyboard shortcuts are added as well, but without default keybindings.
The code looks fine. I will try it out tomorrow if I get time. Also I think the github action is broken... |
Thanks @gustavcedersjo! Hopefully will have time to look at this one tonight. |
Hey @gustavcedersjo - nice work. I like it. Is everyone happy with the description of these shortcuts?:
it definitely fits the decription for Otherwise, am approving this and will merge tomorrow evening. Jay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Great work @gustavcedersjo.
Maybe |
When I first made the patch, I called it something along the lines of your suggestion, @Lythenas, but I changed it when I saw the other settings. The |
P.S.@gustavcedersjo, we've trying a thing atm where we put up a donation link from contributors of PRs etc. (if they want) - see #723 (comment). Feel free to message me or comment here if you would like to have a donation link added. (can also leave a comment on https://confluence.jaytaala.com/display/AJT/ - I won't make any comment there re this public btw) . |
Add commands to switch to the window above (or below), but fall back to switching to the workspace above (or below) if there was no window above (or below).
Keyboard shortcuts are added as well, but without default keybindings.
Issue #847