Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands switch-(up/down)-or-else-workspace #850

Merged
merged 5 commits into from
May 7, 2024

Conversation

gustavcedersjo
Copy link
Collaborator

Add commands to switch to the window above (or below), but fall back to switching to the workspace above (or below) if there was no window above (or below).

Keyboard shortcuts are added as well, but without default keybindings.

Issue #847

jtaala and others added 3 commits April 28, 2024 15:54
Add commands to switch to the window above (or below), but fall back to
switching to the workspace above (or below) if there was no window above
(or below).

Keyboard shortcuts are added as well, but without default keybindings.
@Lythenas Lythenas changed the base branch from release to develop May 5, 2024 19:42
@Lythenas
Copy link
Collaborator

Lythenas commented May 5, 2024

The code looks fine. I will try it out tomorrow if I get time.

Also I think the github action is broken...

@jtaala
Copy link
Collaborator

jtaala commented May 5, 2024

Thanks @gustavcedersjo! Hopefully will have time to look at this one tonight.

@jtaala
Copy link
Collaborator

jtaala commented May 6, 2024

Hey @gustavcedersjo - nice work. I like it.

Is everyone happy with the description of these shortcuts?:

Switch to the above window (no workspace boundary)
Switch to the below window (no workspace boundary)

it definitely fits the decription for Switch to the above window (no monitor boundary) etc. Any simpler way to describe these? (let me know if anyone has any bright ideas there).

Otherwise, am approving this and will merge tomorrow evening.

Jay.

Copy link
Collaborator

@jtaala jtaala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work @gustavcedersjo.

@Lythenas
Copy link
Collaborator

Lythenas commented May 6, 2024

Switch to the above window (no workspace boundary)
Switch to the below window (no workspace boundary)

Maybe Switch to window or workspace above/below? Since we are switching to another workspace and not just switching a window if there is no window above/below.

@gustavcedersjo
Copy link
Collaborator Author

When I first made the patch, I called it something along the lines of your suggestion, @Lythenas, but I changed it when I saw the other settings. The switch-gobal-* could also be called something like Switch to window or monitor above/below.

@jtaala
Copy link
Collaborator

jtaala commented May 6, 2024

How's this?

image

@jtaala jtaala merged commit c497307 into paperwm:develop May 7, 2024
@jtaala
Copy link
Collaborator

jtaala commented May 7, 2024

P.S.@gustavcedersjo, we've trying a thing atm where we put up a donation link from contributors of PRs etc. (if they want) - see #723 (comment).

Feel free to message me or comment here if you would like to have a donation link added. (can also leave a comment on https://confluence.jaytaala.com/display/AJT/ - I won't make any comment there re this public btw) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants