Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make generic data primitives EvmEnvProvider #12981

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat: make generic data primitives EvmEnvProvider #12981

merged 1 commit into from
Nov 29, 2024

Conversation

htiennv
Copy link
Contributor

@htiennv htiennv commented Nov 28, 2024

Closes #12943

emhane
emhane approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Rjected
Rjected approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, although given we only use the header here, makes me wonder if we should limit the constraint to just implementing the Header trait

@Rjected Rjected added this pull request to the merge queue Nov 29, 2024
Merged via the queue into paradigmxyz:main with commit 55ddaab Nov 29, 2024
41 checks passed
@htiennv htiennv deleted the evm-env branch November 30, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@Rjected Rjected Rjected approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic data primitives EvmEnvProvider
3 participants
@htiennv @Rjected @emhane