Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minifier: remove duplicate selectors #240

Open
yisibl opened this issue Jul 22, 2022 · 6 comments · May be fixed by #696
Open

minifier: remove duplicate selectors #240

yisibl opened this issue Jul 22, 2022 · 6 comments · May be fixed by #696
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yisibl
Copy link
Contributor

yisibl commented Jul 22, 2022 

h1,h2,h3,h1,h3{
  color:blue
}

div.class,div.class,.class{
  color:blue
}

https://parcel-css.vercel.app/#%7B%22minify%22%3Atrue%2C%22nesting%22%3Atrue%2C%22customMedia%22%3Atrue%2C%22cssModules%22%3Afalse%2C%22analyzeDependencies%22%3Afalse%2C%22targets%22%3A%7B%22chrome%22%3A6225920%7D%2C%22source%22%3A%22h1%2Ch2%2Ch3%2Ch1%2Ch3%7B%5Cn%20%20color%3Ablue%5Cn%7D%5Cn%5Cndiv.class%2Cdiv.class%2C.class%7B%5Cn%20%20color%3Ablue%5Cn%7D%22%2C%22unusedSymbols%22%3A%5B%5D%2C%22version%22%3A%22local%22%7D
@devongovett
Copy link
Member

Seems reasonable. When does this happen in real-world code though?

@devongovett devongovett added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2022
@yisibl
Copy link
Contributor Author

yisibl commented Aug 17, 2022

Seems reasonable. When does this happen in real-world code though?

I'm not quite sure if there might be such a code, my guess is that it might be a clerical error or generated by the preprocessor.

@LeoniePhiline
Copy link
Contributor

I'd like to take a look at this one.

@LeoniePhiline
Copy link
Contributor

I won't manage currently to work on this. Free to take!

@R-Bower
Copy link

R-Bower commented Mar 17, 2023

For anybody still looking for a solution here, I've managed to combine cssnano and postcss-lightningcss to achieve the desired result. Note that this will require postcss.

@qsliu2017
Copy link

I'd like to have a try

@qsliu2017 qsliu2017 linked a pull request Mar 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

minify selectors qsliu2017/lightningcss
5 participants
@devongovett @yisibl @R-Bower @LeoniePhiline @qsliu2017