Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Map as subscription params #622

Open
nicolaiunrein opened this issue Mar 30, 2021 · 1 comment
Open

Allow Map as subscription params #622

nicolaiunrein opened this issue Mar 30, 2021 · 1 comment

Comments

@nicolaiunrein
Copy link

In jsonrpc-core-client when subscribing only parameters that serialize to Array of Null are allowed. Would it be possible to allow Map as well? I cloned the repo and added Map as a valid type. It seems to work fine but wonder why there is such a restriction. Maybe I'm missing something?
@nicolaiunrein nicolaiunrein changed the title Allow Object as subscription params Allow Map as subscription params Mar 30, 2021
@nicolaiunrein
Copy link
Author

If you like I also created a PR #623 for this. Feel free to reject if there is anything I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolaiunrein