Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages for stable2409-1 are missing #6206

Open
2 tasks done
pandres95 opened this issue Oct 23, 2024 · 7 comments
Open
2 tasks done

Packages for stable2409-1 are missing #6206

pandres95 opened this issue Oct 23, 2024 · 7 comments
Assignees
Labels
I2-bug The node fails to follow expected behavior.

Comments

@pandres95
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

I'm getting the following error (same with all the crates' versions listed below) when trying to update to stable2409-1 using psvm:

    Updating crates.io index
error: failed to select a version for the requirement `emulated-integration-tests-common = "^14.1.0"`
candidate versions found which didn't match: 14.0.0, 13.0.0, 11.0.0, ...
location searched: crates.io index
required by package `asset-hub-kusama-emulated-chain v1.0.0 (/Users/**/**/runtimes/integration-tests/emulated/chains/parachains/assets/asset-hub-kusama)`

The main reason behind this issue is that these versions seem to be missing from crates.io.

Packages affected

Steps to reproduce

I ran the update using this command:

psvm --version stable2409-1

pvsm bumped the versions to some crates (at least 6 or 7 of them). After that, I started getting those cargo errors, just to find out that those versions didn't exist at all on crates.io. 😅

When trying to update to stable2409, it worked out perfectly fine (see runtimes#490). But failed when trying to update to stable2409-1 (here).

@pandres95 pandres95 added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Oct 23, 2024
@pandres95 pandres95 changed the title Packages for stable2409 are missing Packages for stable2409-1 are missing Oct 23, 2024
@clangenb
Copy link
Contributor

So the patch publishing for not the most recent stable is mostly broken due to a version conflict on crates IO for the most recent stable, see polkadot-fellows/runtimes#493 (comment).

Wouldn't the solution to this be to just simply bump minor versions whenever a new stable version is released? Then the patch versions can be reserved for patches to the individual stable releases. I know this would kind a break the semantic versioning, but I think it is a very simple fix that helps us actually releasing patches on crates.io for older stable versions.

@acatangiu
Copy link
Contributor

@ggwpez @EgorPopelyaev @Morganamilo this is high priority IMO, looks like we have a broken patch release mechanism potentially blocking properly delivering security fixes or other high priority fixes.

@ggwpez
Copy link
Member

ggwpez commented Oct 24, 2024

PSVM is picking the version from the branch, so it has them before they land on crates-io.

@Morganamilo do you know when sc-network for example will land? Its version is 0.45.1 on the branch but 0.45.0 on crates-io.

About the versioning conflict that @xlc highlight, I am not sure how it is currently handled. Possibly it should bump the minor version even for patch bumps, if the current patch version on crates-io is not zero. Have to ask @Morganamilo how this is currently handled.

@Morganamilo
Copy link
Contributor

I'm working on fixing this now. Will try to get it fixed asap.

@acatangiu
Copy link
Contributor

About the versioning conflict that @xlc highlight, I am not sure how it is currently handled. Possibly it should bump the minor version even for patch bumps, if the current patch version on crates-io is not zero. Have to ask @Morganamilo how this is currently handled.

This is the concerning part to me. It currently breaks our stable releases support.

@bkchr
Copy link
Member

bkchr commented Nov 6, 2024

@Morganamilo was this solved? If yes, please close the issue.

@evilrobot-01
Copy link

Seems to be the same problem for stable2407-4

psvm -v stable2407-4
❯ cargo b -r
    Updating crates.io index
error: failed to select a version for the requirement `asset-hub-westend-runtime = "^0.25.1"`

@acatangiu acatangiu removed the I10-unconfirmed Issue might be valid, but it's not yet known. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior.
Projects
None yet
Development

No branches or pull requests

7 participants