Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to ensure coretime scheduler works with under-assigned cores #6397

Open
seadanda opened this issue Nov 6, 2024 · 7 comments · May be fixed by #7294
Open

Add tests to ensure coretime scheduler works with under-assigned cores #6397

seadanda opened this issue Nov 6, 2024 · 7 comments · May be fixed by #7294
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.

Comments

@seadanda
Copy link
Contributor

seadanda commented Nov 6, 2024

Add regression tests to ensure the behaviour is maintained with future changes.

Originally posted by @seadanda in #6384 (comment)
@seadanda seadanda added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Nov 6, 2024
@seadanda seadanda mentioned this issue Nov 6, 2024
Closed
@rainb0w-pr0mise
Copy link
Contributor

Can I pick this up?

@seadanda
Copy link
Contributor Author

seadanda commented Nov 7, 2024

@spanow was already working on the main issue, of which this is a part. Are you OK to give them a couple of days to reply before you take it on? It's likely they'll still be interested
There are other good issues to get started with while you wait :)

@rainb0w-pr0mise
Copy link
Contributor

@spanow was already working on the main issue, of which this is a part. Are you OK to give them a couple of days to reply before you take it on? It's likely they'll still be interested There are other good issues to get started with while you wait :)

Yeah Thanks @seadanda

@seadanda
Copy link
Contributor Author

@rainbow-promise if you're still interested it looks like @spanow didn't take this in the end

@rainb0w-pr0mise
Copy link
Contributor

rainb0w-pr0mise commented Nov 26, 2024 •
edited
Loading

@rainbow-promise if you're still interested it looks like @spanow didn't take this in the end

Thanks for the heads up @seadanda, yes still interested.

I'll have a few more follow-up questions soon, while I look more into it.

Could you maybe drop relevant links if necessary.

@seadanda
Copy link
Contributor Author

#6384 contains some details further to the PR linked above.

The aim is to add regression tests for the new functionality added in the PR

@Nathy-bajo Nathy-bajo linked a pull request Jan 22, 2025 that will close this issue
Open
@Nathy-bajo
Copy link
Contributor

@seadanda I dropped a PR on this #7294
Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add regression test for #6384 Nathy-bajo/polkadot-sdk
3 participants
@seadanda @Nathy-bajo @rainb0w-pr0mise