-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store Justifications along with the rest of the block #147
Comments
I'll work on this guy |
After trying for an hour or two to get the postgres scripts to work with a docker container, I created a docker-compose.yaml with the URL defaults that makes spinning it up the DB super easy for those (like me) who don't know postgres ins and outs. Is this something worth including in the PR? version: '3'
services:
# container name is:
pg-substrate-archive:
image: 'postgres:latest'
ports:
- 5432:5432 # localhost_port:container_port ; don't change container_port
environment:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: 123 # change me
POSTGRES_DB: kusama # default db name basically sets up a db instance with user/pass as docker tl;dr we can stick in the readme: |
Yeah that would be great! Would start the journey to closing #206 as well, but yeah definitely a worthy addition imo |
I think it would be best as a separate PR; it's orthogonal to justifications. I'm fine with anything that makes the first-use experience better but I do not want to bless Docker as the "preferred way" of running |
Since justifications are nullable values, I think this is blocked until this is solved: launchbadge/sqlx#1294 (comment). |
For one reason or another Justifications aren't stored in the Postgres Database.
Justification is present on the
SignedBlock
field ofBlock
though, so it would be nice to store it if it exists. This requires a new SQL migration that creates aJustification
column as abytea
field. It is possible for justification to be null for a block, so the columns should reflect this.The SQL Inserts should be modified to add the justification as well:
substrate-archive/substrate-archive/src/database.rs
Line 88 in 7c88689
The text was updated successfully, but these errors were encountered: