Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Buttons #18

Open
phlexib opened this issue Jul 29, 2020 · 4 comments
Open

Push Buttons #18

phlexib opened this issue Jul 29, 2020 · 4 comments

Comments

@phlexib
Copy link
Contributor

phlexib commented Jul 29, 2020

I'd like to add the Push a Button.
Should it be part of the v1-migration branch or a new one ?

@github-actions
Copy link

Thanks for creating your first issue for coda-js and contributing!

@parker-codes
Copy link
Owner

@phlexib Sounds great! I think it depends on when you'd like it merged and usable. Since it may be a couple weeks until the v1 migration is complete, perhaps you'd like to add it to the master branch. It would need to be updated to match the new Coda API version though, so it might take double the work.

I recommend adding the pushButton() method to the general Coda class and also the consecutive Doc, Table, and Row models so that we keep the eloquent API structure. If you're unsure what I mean, just ask!

@phlexib
Copy link
Contributor Author

phlexib commented Jul 29, 2020

@parker-codes I think I get it. It will follow the https://coda.io/developers/apis/v1#operation model.
I'll work on it on a new branch on my fork for now, as I'm already using the v1 api. It shouldn't be too much hassle to bring it when v1-migration is done.

@parker-codes
Copy link
Owner

@phlexib Last night I tagged the release of v4.0.0, so you can add this to the updated master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants