New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On azerty keyboard, "w" is triggered by both "w" and "z" #99

Open

jean-emmanuel opened this issue Mar 19, 2020 · 1 comment

Contributor

jean-emmanuel commented Mar 19, 2020

Hi,
With an azerty keyboard, the input object can looks like this:

{
  type: 'keyDown',
  key: 'w',
  code: 'KeyZ',
  // ...
}
// or 
{
  type: 'keyDown',
  key: 'z',
  code: 'KeyW',
  // ...
}

The input comparison fails to differentiate these cases. It does not occur with electron global shortcuts.

Contributor Author

jean-emmanuel commented Mar 19, 2020

It seems the root cause is toKeyEvent('w') returning { key: 'w', code: 'KeyW' } regardless of the keyboard layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment