Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error compilation with on vaadin 8 #85

Open
radekpakula opened this issue Jun 4, 2017 · 5 comments
Open

Error compilation with on vaadin 8 #85

radekpakula opened this issue Jun 4, 2017 · 5 comments

Comments

@radekpakula
Copy link

radekpakula commented Jun 4, 2017

Hi there is problem in WidgetsetDefinition in file fi/jasoft/dragdroplayouts/public/DragDropLayoutsWidgetSet.gwt.xml

When try compile widgetset on my project (vaadin 8, addon version 1.4.2) i recive error that "com.vaadin.v7.Vaadin7WidgetSet" is not found. I remove problematic line and recompile widgetset in my project. Looks good and work fine.

//Edit
It looks that in branch tagged 1.4 file looks fine. Problem occurs with package addon version 1.4.2 in vaadin repository. File fi/jasoft/dragdroplayouts/public/DragDropLayoutsWidgetSet.gwt.xml is out of date.

@ripla
Copy link
Contributor

ripla commented Jun 6, 2017

@radekpakula thank you for noticing this issue. It's caused by the fact that we depend on the compatibility widgetset from Framework 8. If you don't have the compatibility packages (see for example https://vaadin.com/vaadin-fw8-documentation-portlet/framework/migration/migrating-to-vaadin8.html), then the compilation will fail. In the future we could consider somehow splitting the compatibility classes to a separate download.

@basisbit
Copy link

@ripla at https://vaadin.com/directory#!addon/dragdroplayouts it says that this addon supports vaadin 8. Please either provide information on how to get it to work with vaadin 8 (for example which "compatibility" maven packages are missing exactly?) or change the compatibility information in the vaadin directory.

@ripla
Copy link
Contributor

ripla commented Jun 29, 2017

@basisbit you most likely need these maven artefacts:

  • vaadin-compatibility-server
  • vaadin-compatibility-client
  • vaadin-compatibility-shared

@hoerup
Copy link

hoerup commented Sep 27, 2017

see #88 to get a jar file that build cleanly with vaadin8 without the need for compability packages

@alexxtaurus
Copy link

I'm still see the same issue for addon from vaadin repository for the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants