Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emu-MPS] tdvp benchmark - only docs #13

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

[Emu-MPS] tdvp benchmark - only docs #13

wants to merge 20 commits into from

Conversation

sgrava
Copy link
Contributor

@sgrava sgrava commented Jan 16, 2025 •
edited
Loading

Resolves #9

For convenience I only add the documentation part here.
Since we are refactoring them here, the actual bechmark that generates new plots will be added separately.

Main changes are:

  • docs/benchmarks/index.md
  • docs/advanced/resource_estimation.md
  • fixing docstring of MPS class

To build the docs of this branch locally and see the result:

git switch sg/9-emu-mps-number-of-qubits-bond-dimension-benchmark
pip install -r ./doc_requirements.txt
mkdocs serve --open

@sgrava sgrava linked an issue Jan 16, 2025 that may be closed by this pull request
[Emu-MPS] number of qubits bond dimension benchmark #9
Open
3 tasks
@sgrava sgrava changed the title Draft: [Emu-MPS] tdvp benchmark [Emu-MPS] tdvp benchmark - only docs Jan 21, 2025
murogrande
murogrande reviewed Jan 21, 2025
View reviewed changes
docs/advanced/resource_estimation.md

$$
2,4,8,16...,16,8,4,2
$$
Copy link
Contributor

@murogrande murogrande Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is a bad to add a basic example, using 5 or 6 qubits? To add more clarity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the page dedicated to the MPS format, and we link to that.
I think it is enough for the moment.
But in the future yeah definitely more examples would be cool.

@murogrande
Copy link
Contributor

murogrande commented Jan 21, 2025 •
edited
Loading

related to the equations, I still need to check them but I like the documentation. Nice job !
Is there a way to see the pre-view of the documentation?

@sgrava
Copy link
Contributor Author

sgrava commented Jan 21, 2025

related to the equations, I still need to check them but I like the documentation. Nice job ! Is there a way to see the pre-view of the documentation?

Unfortunately, for the moment you need to locally move to this branch and do:

pip install -r ./doc_requirements.txt
mkdocs serve

then open with your browser the locally built docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murogrande murogrande murogrande left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Emu-MPS] number of qubits bond dimension benchmark
2 participants
@sgrava @murogrande