Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose which symbols to explicilty export at the top level of pasqal_cloud #148

Open
HGSilveri opened this issue Nov 8, 2024 · 0 comments

Comments

@HGSilveri
Copy link
Contributor

HGSilveri commented Nov 8, 2024

In #147 , I'm marking BaseConfig, EmulatorType, Endpoints as symbols explicitly exported at the pasqal_cloud-level because these objects are being called in pulser_pasqal as pasqal_cloud.X and mypy complained about this.

However, I'm sure there are other symbols that would make sense to explicitly export so it's weird to be exporting only these three.

For clarification, there are (at least) two ways to signal a symbol as "explicitly exported":

  1. Redundant imports, ie from module import X as X (this is what I did in [FEAT] Incorporate pulser-pasqal package in the pasqal-cloud repo #147)
  2. Include it in the __all__ module attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant