Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default backup dir shouldn't be set to /tmp #2

Open
AnatomicJC opened this issue Mar 26, 2024 · 2 comments
Open

Default backup dir shouldn't be set to /tmp #2

AnatomicJC opened this issue Mar 26, 2024 · 2 comments

Comments

@AnatomicJC
Copy link

Hi 👋

You shouldn't set /tmp as default backup_dir here: https://github.com/passbolt/lab-passbolt-admin-scripts/blob/main/backup.sh#L14-L15

/tmp is a non-persistent volume who is cleaned on each reboot of any Linux server so users will loose their backups.

/var/tmp is persistent and data will survive a server reboot.

Best,

@itvexesme
Copy link
Contributor

itvexesme commented Mar 31, 2024

Actually /var/tmp is also not the best choice here. You shouldn't store backup of passbolt on passbolt instance.
Find some secure place for that purpose.

/tmp is just a place backup.sh script put the backup for you, and you need to care about it after that step. You should store it securely somewhere and remove /tmp/backup-*.tar.gz from the server.

@AnatomicJC
Copy link
Author

I totally agree with you.

Globally, backups should never be stored on the passbolt server itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants