From what I'm seeing it looks like we can't produce a valid eip 712 signature without a domain seperator https://eips.ethereum.org/EIPS/eip-712#definition-of-typed-structured-data-%F0%9D%95%8A . It seems like it would still be a valid VC but not a valid

Unfortunately it doesn't look like we can build the VC without providing types to verifyCredential. Writing this part mostly so I don't forget where everything is since there is so much in didkit. here is where they are checking for passed types. If types don't exist generate_proof_info is called and an empty hash is returned as the domain value.

After further investigation we have determined that there are some differences between didkits eip712 signature and ethers/solidity. If types are not provided to the VC gneration didkit will sign an empty hash {} as the domain separator which is invalid within solidity/ethers/

Because of this we've decided to keep the types as part of the signature. https://github.com/digitalmnt/passport-vc-verification/tree/main can still act as an example of verifying a EIP712 signed VC

I have created this script https://github.com/nutrina/passport-vc-verification/blob/test_eip712/utils/didkitVerify.ts
that should verify the validity of a credential with ethers.

This works for credentials generated using: https://github.com/nutrina/passport-vc-verification/blob/test_eip712/utils/didkitSign.ts

But this does not work for credentials generated with Passport (When run on my local).

We have limited ourselves to validating the credentials with ethers, will create a SC for validation at a later point