Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletConnect Issue #1451

Closed
Jkd-eth opened this issue Jul 7, 2023 · 3 comments · Fixed by #1446, #1469 or passportxyz/passport-scorer#311
Closed

WalletConnect Issue #1451

Jkd-eth opened this issue Jul 7, 2023 · 3 comments · Fixed by #1446, #1469 or passportxyz/passport-scorer#311
Assignees
Labels

Comments

@Jkd-eth
Copy link
Contributor

Jkd-eth commented Jul 7, 2023

Overview
Users are having trouble connecting to Passport using wallet connect (Zerion wallet) due to changes with the WalletConnect integration

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Observed behavior
A clear and concise description of what the observed behavior of the system.

Expected behavior
A clear and concise description of what you expected the system to do.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here that will assist in triaging the bug. I.e. Browser information, unique identifiers, etc.

@Jkd-eth Jkd-eth added the Support label Jul 7, 2023
@Jkd-eth Jkd-eth added this to Passport Jul 7, 2023
@Jkd-eth Jkd-eth moved this to Backlog in Passport Jul 7, 2023
@tim-schultz
Copy link
Collaborator

tim-schultz commented Jul 7, 2023

This PR should be all that is needed to resolve this, unless web3onboard releases another update to accommodate metamask mobile. This issue should provide progress updates blocknative/web3-onboard#1809

@Adamj1232
Copy link

Hi @schultztimothy!
X-posting here as well - we have pinpointed the issue. MetaMask when handling a connection through WalletConnect requires a URL to be passed.
This previously was populated within the WalletConnect package as the web3OnboardInit.appMetaData.explorer property.
I have an open PR to add a WC init prop to define this more clearly as well as enhanced validation and documentation around this.
To resolve this issue in the short term please pass in the dapp URL into web3OnboardInit.appMetaData.explorer or you can wait until the noted PR is in alpha to test with the walletconnect init prop dappUrl

@tim-schultz tim-schultz self-assigned this Jul 11, 2023
@tim-schultz tim-schultz moved this from Backlog to In Progress (WIP) in Passport Jul 11, 2023
@tim-schultz
Copy link
Collaborator

Hi @Adamj1232 sounds good thanks for following up here!

@tim-schultz tim-schultz moved this from In Progress (WIP) to Product/UX Review in Passport Jul 11, 2023
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Jul 12, 2023
@erichfi erichfi removed this from Passport Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment