Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelock Controller doesn't allow execute any method of other contract #50

Open
xgreenx opened this issue Aug 17, 2021 · 0 comments
Open

Timelock Controller doesn't allow execute any method of other contract #50

xgreenx opened this issue Aug 17, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@xgreenx
Copy link

xgreenx commented Aug 17, 2021

The current implementation of Timelock Controller requires on_call methods on called account. When the initial implementation from OpenZeppelin allows calling any method with any data.

Without this feature, this contract doesn't make sense=)

BTW, without feature this comment is incorrect and you missed this check.
@fanyang1988 fanyang1988 added the enhancement New feature or request label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fanyang1988 @xgreenx