Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Add deploy functionality #149

Open
VargSupercolony opened this issue Oct 11, 2021 · 4 comments
Open

[feature request] Add deploy functionality #149

VargSupercolony opened this issue Oct 11, 2021 · 4 comments

Comments

@VargSupercolony
Copy link
Contributor

For bigger projects, it would be nice to have deploy functionality, similar to hardhat.

Basically, instead of writing individual scripts, a developer would write the deploy functions, which would execute synchronously within one API instance (instead of doing for script in ./deploy/*; do npx redspot run "$script" --no-compile; done, which would in turn connect and disconnect node API).

@ii-ii-ii
Copy link
Member

As far as I know, hardhat doesn't provide a deploy command either, https://hardhat.org/tutorial/deploying-to-a-live-network.html#_7-deploying-to-a-live-network. Did I miss something?

@ii-ii-ii
Copy link
Member

You mean the deploy function? Can't this function work? https://github.com/patractlabs/redspot/blob/master/examples/erc20/scripts/deploy.ts#L24

@VargSupercolony
Copy link
Contributor Author

As far as I know, hardhat doesn't provide a deploy command either, https://hardhat.org/tutorial/deploying-to-a-live-network.html#_7-deploying-to-a-live-network. Did I miss something?

Hardhat indeed does not provide hardhat deploy command. It is done by hardhat-deploy plugin. I was curious, if you'd be interested in having such in Redspot.

You mean the deploy function? Can't this function work? https://github.com/patractlabs/redspot/blob/master/examples/erc20/scripts/deploy.ts#L24

This works yeah, but as soon as we get to deploying 15-20 contracts, the deploy file gets convoluted and there is an urge to logically separate the deploys. Obviously, we can do this separation into functions (each function deploys one contract), but that'd mean that we lose dependency management, metadata about each deployment and so on. Please see hardhat-deploy readme.

@ii-ii-ii
Copy link
Member

Well, I think it does look OK. We'll add this in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants