Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Upscale and Focal point setting #295

Open
ccorda opened this issue Oct 10, 2023 · 0 comments
Open

Image Upscale and Focal point setting #295

ccorda opened this issue Oct 10, 2023 · 0 comments

Comments

@ccorda
Copy link
Contributor

ccorda commented Oct 10, 2023

We've been dealing with a couple different but related issues:

  1. When we try and fetch a specific ratio image (for example square), and we have different widths: 1600, 1200, 800, 200, and we want to fetch using srcset -- we don't always get a square image. If a user was to upload a 1500 x 1200 image, and you request SQUARE_1600, you'll actually get the original 15x12 image.

The solution to this might be to upscale images:

Or to do an image calculation after we get the original images.

  1. Editors don't have control of crops.

We've been experimenting with a couple plugin options:

https://wecodepixels.com/shop/theia-smart-thumbnails-for-wordpress/
https://wordpress.org/plugins/presswell-art-direction/

Our ideal outcome is that it's easy for editors to understand how images will be cropped, we get consistent crop output from WP either from upscaling, or from grabbing the WP output, and using object fit to position (factoring in focal point)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant