From 09e4bf3a7653c931ad88f5bf0ed865975e0e9388 Mon Sep 17 00:00:00 2001 From: Andrew Ronaldson Date: Thu, 19 Dec 2024 15:13:53 -0400 Subject: [PATCH 1/2] fix(vertical tabs): text-decoration off Their shouldn't be an underline on the vertical tabs --- .../module/sass/react-catalog-view-extension/_vertical-tabs.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss b/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss index 408366d..a48bb40 100644 --- a/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss +++ b/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss @@ -14,6 +14,7 @@ > a { color: var( --pf-t--global--text--color--regular); + text-decoration: none; display: inline-block; font-size: 13px; padding: 3px 6px 3px 15px; From 92a6c3726a86506d67cd2bd5e2c7863baa1a46d5 Mon Sep 17 00:00:00 2001 From: nicolethoen Date: Tue, 14 Jan 2025 17:29:55 -0500 Subject: [PATCH 2/2] ensure parity between shipped styles and example styls --- .../module/patternfly-docs/content/examples/verticalTab.css | 2 +- .../sass/react-catalog-view-extension/_vertical-tabs.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/module/patternfly-docs/content/examples/verticalTab.css b/packages/module/patternfly-docs/content/examples/verticalTab.css index 2f9ffd3..6d04ae2 100644 --- a/packages/module/patternfly-docs/content/examples/verticalTab.css +++ b/packages/module/patternfly-docs/content/examples/verticalTab.css @@ -18,6 +18,7 @@ } .ws-react-e-vertical-tabs .vertical-tabs-pf-tab > a { color: var(--pf-t--global--text--color--regular); + text-decoration: none; display: inline-block; font-size: var(--pf-t--global--font--size--body--default); padding-block: var(--pf-t--global--spacer--xs); @@ -30,7 +31,6 @@ margin-inline-start: var(--pf-t--global--spacer--md); } .ws-react-e-vertical-tabs .vertical-tabs-pf-tab > a:hover, .ws-react-e-vertical-tabs .vertical-tabs-pf-tab > a:focus { - color: var(--pf-t--global--text--color--regular); background-color: var(--pf-t--global--background--color--action--plain--hover); text-decoration: none; } diff --git a/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss b/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss index a48bb40..b80aca2 100644 --- a/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss +++ b/packages/module/sass/react-catalog-view-extension/_vertical-tabs.scss @@ -24,7 +24,7 @@ &:hover, &:focus { - color: var(--pf-t--global--text--color--brand--hover); + background-color: var(--pf-t--global--background--color--action--plain--hover); text-decoration: none; }