Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL paths aren't split correctly on Windows #18

Open
taradinoc opened this issue Jul 8, 2017 · 0 comments
Open

URL paths aren't split correctly on Windows #18

taradinoc opened this issue Jul 8, 2017 · 0 comments

Comments

@taradinoc
Copy link

taradinoc commented Jul 8, 2017

The path splitting logic assumes all paths will be separated with the system path separator, but on Windows, a tab whose path is a URL will still use the '/' separator even though local file paths use '\'.

A quick workaround is to change all the calls to .split() to use a regex, so they split on both characters; paths are still joined using the system path separator. A more robust solution could detect the path separator for each tab individually, using either the system separator or '/' for splitting and joining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant